DNM: Power make dev-tor with Arti
#7207
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately `podman volume` and `docker volume` are not identical, podman will (sensibly) error if you try to create a volume that already exists unless you pass `--ignore`, which docker doesn't support and is only in podman 4.4+. So we check with `$DOCKER_BIN inspect` first and only create the volume if necessary. And apply the same changes to `make clean` as well. Co-authored-by: deeplow <francisco@freedom.press>
The authenticated onion service stuff is still unmerged (<https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2266>), so we build Arti from the MR and it works! Generating a config.toml file seems much cleaner than adding to `torrc` and generating `.auth` files. The main upside for this is that using Arti is cool and gets it more real-world testing. But the downside is that it takes a non-trivial amount of time to build Arti locally and maybe it's not worth doing until we have pre-package/downloadable binaries. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
The authenticated onion service stuff is still unmerged
(https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2266),
so we build Arti from the MR and it works! Generating a config.toml file
seems much cleaner than adding to
torrcand generating.authfiles.The main upside for this is that using Arti is cool and gets it more
real-world testing. But the downside is that it takes a non-trivial
amount of time to build Arti locally and maybe it's not worth doing
until we have pre-package/downloadable binaries. 🤔
Testing
How should the reviewer test this PR?
Write out any special testing steps here.
Deployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following:
If you added or updated a reference to a production code dependency:
Production code dependencies are defined in:
admin/requirements.inadmin/requirements-ansible.insecuredrop/requirements/python3/requirements.insecuredrop/requirements/python3/translation.in(used in the buildcontainer)
If you changed another
requirements.infile that applies only to developmentor testing environments, then no diff review is required, and you can skip
(remove) this section.
Choose one of the following: